----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/#review73 -----------------------------------------------------------
indra/llcommon/llversionviewer.h <http://codereview.secondlife.com/r/56/#comment34> This is wrong - com.secondlife.indra.viewer is correct. indra/llmessage/llregionflags.h <http://codereview.secondlife.com/r/56/#comment35> shouldn't these lines just be deleted? commented out code is confusing indra/llmessage/llregionflags.h <http://codereview.secondlife.com/r/56/#comment36> delete? indra/llmessage/llregionflags.h <http://codereview.secondlife.com/r/56/#comment39> delete indra/llmessage/llregionflags.h <http://codereview.secondlife.com/r/56/#comment37> why add commented out code? indra/llmessage/llregionflags.h <http://codereview.secondlife.com/r/56/#comment38> delete indra/newview/llviewerregion.h <http://codereview.secondlife.com/r/56/#comment40> please add doxygen-style comments - Oz On 2010-12-22 23:54:00, Merov Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/56/ > ----------------------------------------------------------- > > (Updated 2010-12-22 23:54:00) > > > Review request for Viewer and Andrew Meadows. > > > Summary > ------- > > The object-vs-parcel overlap test is done by building axis-aligned bounding > boxes (AABB) about each prim of the selected objects and then checking for > overlap between those boxes and self- and group-owned parcels. > > > This addresses bug STORM-807. > http://jira.secondlife.com/browse/STORM-807 > > > Diffs > ----- > > indra/llcommon/llversionviewer.h d8fef72af99e > indra/llmath/llbbox.h d8fef72af99e > indra/llmath/llbbox.cpp d8fef72af99e > indra/llmessage/llregionflags.h d8fef72af99e > indra/newview/llviewermenu.cpp d8fef72af99e > indra/newview/llviewerobject.h d8fef72af99e > indra/newview/llviewerobject.cpp d8fef72af99e > indra/newview/llviewerparceloverlay.h d8fef72af99e > indra/newview/llviewerparceloverlay.cpp d8fef72af99e > indra/newview/llviewerregion.h d8fef72af99e > indra/newview/llviewerregion.cpp d8fef72af99e > indra/newview/llvoavatar.cpp d8fef72af99e > > Diff: http://codereview.secondlife.com/r/56/diff > > > Testing > ------- > > > Thanks, > > Merov > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
