On 06/28/10 03:51 PM, Gireesh Nagabhushana wrote:
It now looks good to me. Thanks for fixing all others too.
Thank you.
As a coincidence, Ali (Cc'ed) is about to submit the RTI for the mkstemp
change so I will fix just the err/warn stuff.
v.
Regards,
Gireesh
On Mon, Jun 28, 2010 at 6:48 PM, Vladimir Kotal<vladimir.ko...@sun.com> wrote:
On 06/28/10 01:57 PM, Gireesh Nagabhushana wrote:
You may add "sgsmsg:" in the error message similar to others.
@@ -88,6 +88,7 @@
"at line\n",
* Errmsg_nmem = "sgsmsg: memory allocation failed: %s\n",
* Errmsg_opne = "sgsmsg: file %s: open failed: %s\n",
+ * Errmsg_tmp = "cannot create temporary file",
* Errmsg_wrte = "sgsmsg: file %s: write failed: %s\n",
* Errmsg_read = "sgsmsg: file %s: read failed %s\n",
* Errmsg_stnw = "sgsmsg: st_new(): failed: %s\n",
That's actually on purpose since err() will print the program name by
itself. But this brings up good point since the second call will print the
program name twice. Hence, I have modified the calls using the Errmsg
strings to use warn()/err() family. As a result the code is easier on the
eyes now. Note that some of the error strings do not print the errno string
so they are used with the x-prefixed variants of warn(), warnx(). Also, the
usage string is still printed with fprintf() cause it does not need the
program name prefix. All other error messages should be printed via
err()/warn() family.
webrev is refreshed.
v.
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
