I think this looks good. Some comments, questions, suggestions
follow.
- Stephen
----
man.c:
225 - 227. MAN_USAGE lacks mention of "-p".
420,
505,
.... (Style.) Elide spaces on inside of parentheses:
"( catmando == 0 )" -> "(catmando == 0)", etc. cstyle will warn
about this.
462. (Nit.) Update comment to include man's -p case (or delete)?
504. (Style.) Elide space on inside of left outer parenthesis.
538. (Sp.) Either "with out" -> "with no" or "with out" ->
"without".
1633. (Style.) Space after comma.
2227. Why is this assignment needed?
2244. (Sp.) "paranthesis" -> "parentheses".
3061 - 3062. Maybe "dupnode" instead of "dev_ino cache"? (Only
mentioned here.)
3064ff. Is there a reason not to just remove the duplicate sections
from the list rather than setting their first character to NUL
(and then having special handling in print_manpath())? (Real
question: why an array (and its awkward realloc() requirements)
and not a list?)
3102,
3123,
3145. (Style.) Space after return keyword.
3119 - 3124. How does this comment match up with the stat()? (The
other question it raises is that of a directory tree that doesn't
deliver an explicit bin, but has manual pages in the correct
location: the if (stat()) test eliminates handling such a tree.)
3127. (Nit.) I thought 3120 was "first"? :)
3150. (Sp.) "translatfor" -> "translation"?
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
