Garrett D'Amore wrote:
I sent you review off-list, since I saw the request on IRC before I saw the
request here, further notes on your notes inline.
I've posted a codereview, which I would love to have folks review. This
adds the platform support for SPARCLE (aka Sun Ultra 3) per PSARC 2007/152:
http://cr.grommit.com/~gdamore/douglas/
A few notes. First, the whole review is almost entirely Makefile and
packaging changes, with one notable exception, which is the douglas.c
platmod. This is pretty clearly derived from the grover platmod, which
makes sense douglas is largely a mobile douglas (albeit with some
significant changes.)
Second, this does not include any platform-specific PICL or PMU support
yet. We really need at least some of this (notably the tadpmu driver),
but I want to keep that code separate until we get this first platmod
support in. It also lacks some other platform-specific drivers (such as
the ebutton and sdcard/memstick and synaptics drivers.) Some of those
will be coming soon as well.
I'd suggest that this is incomplete without these, it's certainly incomplete
without tadpmu.
I'd far rather see this go back complete, than go back piecemeal for
ill-defined reasons.
-- Rich
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
