This is an automated email from Gerrit.
?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/140
-- gerrit
commit 8cb99c45f508b20fbac9aa9649374b774cb647d8
Author: Øyvind Harboe <oyvind.har...@zylin.com>
Date: Sun Oct 30 18:36:47 2011 +0100
dsp563xxx: fix missing error propagation found by clang
Change-Id: I7380ce145b4942e21b174f2a810928a877c32bc7
Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>
diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c
index b7f23c7..6a59e86 100644
--- a/src/target/dsp563xx.c
+++ b/src/target/dsp563xx.c
@@ -1323,7 +1323,7 @@ static int dsp563xx_run_algorithm(struct target *target,
int timeout_ms, void *arch_info)
{
int i;
- int retvaltemp,retval = 0;
+ int retval = ERROR_OK;
struct dsp563xx_common *dsp563xx = target_to_dsp563xx(target);
if (target->state != TARGET_HALTED)
@@ -1376,9 +1376,13 @@ static int dsp563xx_run_algorithm(struct target *target,
for (i = 0; i < num_mem_params; i++)
{
if (mem_params[i].direction != PARAM_OUT)
- if ((retvaltemp = target_read_buffer(target,
mem_params[i].address, mem_params[i].size, mem_params[i].value)) != ERROR_OK)
+ retval = target_read_buffer(target,
+ mem_params[i].address,
+ mem_params[i].size,
+ mem_params[i].value);
+ if (retval != ERROR_OK)
{
- retval = retvaltemp;
+ return retval;
}
}
--
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
