On Tue, Aug 30, 2011 at 6:47 PM, Andreas Fritiofson <andreas.fritiof...@gmail.com> wrote: > > > On Tue, Aug 30, 2011 at 9:25 PM, Eric Wetzel <thewet...@gmail.com> wrote: >> >> On the discussion of style, I mentioned that the Linux coding standard >> doesn't really like typedefs. Here is an article from Greg K-H that >> partially addresses the subject: >> http://www.linuxjournal.com/article/5780?page=0,2 >> > Regarding the patches, the ELF types in replacements.h (and their usage in > image.c) should be left as is, because they are replacements for a system > header. Here are some new patch files. They are the same changes I already made, but broken up slightly more at Øyvind's request. No more than 50 lines changed per file, and I split the Elf32 header changes out into the 4th patch file, so it can be ignored if desired. It seems to me like Linux is breaking its own rules with that one: typedefs hiding simple, fixed-width types and typedefs hiding the fact that Elf32_Ehdr/Phdr are structures.
~Eric
0001-style-typedefs-are-evil.patch
Description: Binary data
0002-style-typedefs-are-evil.patch
Description: Binary data
0003-style-typedefs-are-evil.patch
Description: Binary data
0004-style-typedefs-are-evil.patch
Description: Binary data
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
