Hello,
Recently, perhaps the last month or two, I've noticed the Git revision
string is not being appended to base version in the OpenOCD banner.
>From my investigation, I believe that my observation of the problem
was dependent upon my use of a new toolchain and environment, because
the suspect lines seem to have been there for quite some time.
I'm using the (new, as of about 2 months ago) mingw cross-compiler
under Cygwin in Windows 7. `configure` seems to think that I'm trying
to build a release, so it doesn't run guess-rev.sh. I found this in
configure.in:
if test $cross_compiling = no; then
# guess-rev.sh only exists in the repository, not in the released archives
AC_CHECK_FILE("$srcdir/guess-rev.sh", has_guess_rev=yes, has_guess_rev=no)
AC_MSG_CHECKING([whether to build a release])
if test $has_guess_rev = no; then
build_release=yes
else
build_release=no
fi
AC_MSG_RESULT($build_release)
else
build_release=yes
fi
We automatically assume that if we are cross-compiling that we are
building a release. This section was last modified in July 2009, back
in the SVN days, but the commit is here:
http://repo.or.cz/w/openocd.git/commitdiff/00fad24996d6642c6a820cc951c197dddef5734a
Before someone reminded me of the --build and --host options in
configure, I would append CC='gcc-3 -mno-cygwin' to the configure
line. Perhaps this fooled the process into thinking that it wasn't
cross-compiling.
Does anyone think this is a rational assumption? I don't understand
why cross-compiling means we can't check for the existence of a file
(which is what the generated configure script says):
if test $cross_compiling = no; then
# guess-rev.sh only exists in the repository, not in the released archives
as_ac_File=`$as_echo "ac_cv_file_"$srcdir/guess-rev.sh"" | $as_tr_sh`
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for
\"$srcdir/guess-rev.sh\"" >&5
$as_echo_n "checking for \"$srcdir/guess-rev.sh\"... " >&6; }
if eval \${$as_ac_File+:} false; then :
$as_echo_n "(cached) " >&6
else
test "$cross_compiling" = yes &&
as_fn_error $? "cannot check for file existence when cross
compiling" "$LINENO" 5
if test -r ""$srcdir/guess-rev.sh""; then
eval "$as_ac_File=yes"
else
eval "$as_ac_File=no"
fi
fi
eval ac_res=\$$as_ac_File
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_res" >&5
$as_echo "$ac_res" >&6; }
if eval test \"x\$"$as_ac_File"\" = x"yes"; then :
has_guess_rev=yes
else
has_guess_rev=no
fi
I could understand not being able to execute guess-rev.sh in certain
environments. My autotools-fu is weak; can anyone change this? Should
we change it? Does anyone else have a suggestion for getting the Git
revision string back into my banner?
Thanks,
~Eric
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
