On 29 July 2011 16:54, Jie Zhang <jzhang...@gmail.com> wrote: > On Fri, Jul 29, 2011 at 11:41 AM, Spencer Oliver <s...@spen-soft.co.uk> wrote: >> On 29 July 2011 15:32, Jie Zhang <jzhang...@gmail.com> wrote: >>> I happened to find that two previous fixes for set-but-not-used >>> warnings are not correct or not good. This patch should be an >>> improvement. Please review and merge if good. >>> >>> >> >> I am going to look into tis one, as one minute the code is there, next >> minute it was deleted - very strange. >> > To ease your review, the related commits are > > f6315d5e5b7b71515ef051711e5f818a42d6b3b3 smp.c > > 1cfb2287a67c1f78b76583b2e5ed83ca3560b0d5 etb.c >
Cool you patch looks fine - i will commit. Just for info this function was first broken in d7f71e7fe9645fa8c3f88cf6fc9ad438aa6708f3. The whitespace cleanup was a very strict indeed :) Cheers Spen _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development