On 2011-06-04 09:48, Øyvind Harboe wrote:
usbprog.c is clearly broken, I don't think this warning should be "fixed" as
that would be shuffling a bug under the carpet.

Maybe, but it compiles this way (; To me it seems that there was some "old way" of making things, then "new way" come and somebody forgot to remove "old methods" while introducing "new methods". The code is broken anyway and nobody complained for a long long time - there was no functional change to usbprog.c for 1.5 year so either it works (and with my patch it will work the same way for 99%) or it does not and nobody cares (; Same goes for etb.c - no change in over a year.

I've pushed most of the other fixes

Some changes you did not merge look to me just like leftover helper-code. All changes from first patch just cannot change OpenOCD behavior.

, but you'll need to run through two
versions of GCC or try -O3 to get the residual warnings I think.

Try:

CFLAGS="-O3 -g" ./configure ....
make clean
make

Nothing more pops up. What next with the fragments that still cause warnings/errors? I was going to publish a new version on my website, but now I don't know whether I should wait a while for a better fix or maybe disable Werror and proceed...

4\/3!!
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to