Please don't mix the two issues. My patch fixes an endianness problem when 
OpenOCD is build for running on a big endian host. For little endian host 
everything works as usual.


The second problem is swapping endian twice when using mdw command - as 
explained in my mail yesterday. You just have to check if mdw shows different 
output when setting target as little or big endian.

After a closer look I noticed that even target_checksum_memory (target.c) makes 
endianness swapping. Why not dump_image? I'm not sure if it is intended. 
Changing this behaviour would effect other targets too.

BR,
Stefan

-----Ursprüngliche Nachricht-----
Von: Drasko DRASKOVIC [mailto:drasko.drasko...@gmail.com] 
Gesendet: Freitag, 27. Mai 2011 12:58
An: Øyvind Harboe
Cc: Mahr, Stefan; openocd-development@lists.berlios.de
Betreff: Re: [Openocd-development] [PATCH] mips target

On Thu, May 26, 2011 at 2:15 PM, Øyvind Harboe <oyvind.har...@zylin.com> wrote:
> This patch fixes an obvious bug.

It's not so obvious to me. I'll have to take a closer look.


> Unless I hear objections, I will merge.

I can check on Monday or Tuesday. I am very suspicious because I spent
several weeks integrating the changes and I would be surprised that I
overlooked the fact that mdw displays inversed bytes...

On the first look, flipping drscan_32() bits will funk up
mips32_pracc_fastdata_xfer() and all procedures that in mips32_pracc.c
that use it to check 32bit regs.
Well, we know that now mips32_pracc_fastdata_xfer() works correctly
after my patches. I want to say that from my point of view drscan_32()
works correctly.

Will have to check deeper...

BR,
Drasko
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to