Am 12/17/2010 10:38 PM, schrieb Steve Bennett:
>> +    # setup expansion bus CS
>> +    
>> ##########################################################################
>> +    mww 0xc4000000  0xbd113842  #CS0  : Flash, write enabled @0x50000000
> Tcl only recognises comments at the beginning of a command, so "#CS0" etc.
> will be passed to the command. However I note that other config files do this
> too, and I'm sure you've tried this, so there may be some "magic" in the 
> openocd
> command handling which allows this. Normally you would need to write 
> ";#CS0..."
That seems to be fixed now ... I modified my files accordingly.

>> +
>> +    global IXP42x_SDRAM_64MB_16Mx16_1BANK
>> +    ixp42x_init_sdram $IXP42x_SDRAM_64MB_16Mx16_1BANK 2100 3
> You could do this one line instead:
>
> +    ixp42x_init_sdram $::IXP42x_SDRAM_64MB_16Mx16_1BANK 2100 3
That works and looks a lot better.

> I suspect you can omit all of the global statements below here.
> I think this script is already being evaluated at global scope.
>
>> +
>> +# register constants for IXP42x SDRAM controller
>> +global IXP425_SDRAM_IR_MODE_SET_CAS2_CMD
>> +global IXP425_SDRAM_IR_MODE_SET_CAS3_CMD
>> +set IXP425_SDRAM_IR_MODE_SET_CAS2_CMD       0x0000
>> +set IXP425_SDRAM_IR_MODE_SET_CAS3_CMD       0x0001
That part does not work - if I omit the "global"s, I get errors whenever
the variable is accessed. I would have expected to be in global context,
but as I said, my TCL knowledge is not much.

Thanks for your comments!

cu
Michael
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to