Øyvind Harboe wrote:
> Which is better? (whatever "better" is)
> 
> This:
> 
> if {[info exists CHIPNAME]} {
>    set  _CHIPNAME $CHIPNAME
> } else {
>    set  _CHIPNAME at91r40008
> }

All these blocks in the target files have really annoyed me.


> or this:
> 
> set _CHIPNAME [defaultval $CHIPNAME at91r40008]

Significantly better.


> # Std proc to be added
> proc defaultval {varname defval} {
>     if {[uplevel "info exists $varname"]} {
>         return $varname
>     } else {
>         return $defval
>     }
> }

Acked-by: Peter Stuge <pe...@stuge.se>
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to