On Wed, Aug 4, 2010 at 1:01 AM, Michael Schwingen <rincew...@discworld.dascon.de> wrote: > On 08/03/2010 12:01 PM, zeal wrote: >> >> This patch add the below commands (just for determining stuff). >> >> 1. read_bits for reading Fuse/Lock bits. >> 2. read_byte for reading Signature/Calibration byte. >> > > This looks good - however, I have issues with the command names: both names > do not represent the function of the commands: > - read_bits: it reads & dispays the *fuse* bytes, in byte form - why > "bits"? I would have expected "read_fuses" or something along that lines. > Yes. Just from AVR's datasheet. It calls that "Fuse Bits". Yours is better since that function can only read fuse.
> - read_byte: which byte? There are lots of bytes that can be read ;-) > "read_calibration" would indicate what the command really does. > This could be done by <type> parameter. Read calibration or signature are so similar. -- Thanks & Regards zeal _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
