> +struct tms_command {
> +       /** How many bits should be clocked out. */
> +       unsigned        num_bits;
> +       /** The bits to clock out; the LSB is bit 0 of bits[0].  */
> +       uint8_t         *bits;

Tiny comment:

Use uint32_t here, rather than 8 bits. Why 8 bits? There is no
big/small endian issue here, lsb is shifted out first.

The only reason I mention this is because I'd like to see the rest of
the jtag api move away from 8 bit vectors to something more sensible
(32 really).

-- 
Øyvind Harboe
US toll free 1-866-980-3434 / International +47 51 63 25 00
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to