The patch didn't make it through. Please check this patch and I'll commit it.
Sorry about breaking the mips stuff & thanks for spotting it! -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer
From 308f6494e8c1281f4f17e821911043267e844ca2 Mon Sep 17 00:00:00 2001 From: Jerry Ling <jerry_l...@draytek.com> Date: Mon, 23 Nov 2009 12:11:54 +0100 Subject: [PATCH] mips: fix gaffe when removing dynamic array allocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Classic sizeof() gaffe. Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com> --- src/target/mips32_pracc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/target/mips32_pracc.c b/src/target/mips32_pracc.c index 40627e1..4f9a704 100644 --- a/src/target/mips32_pracc.c +++ b/src/target/mips32_pracc.c @@ -620,7 +620,7 @@ int mips32_pracc_write_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int c memcpy(¶m_in[2], buf, count * sizeof(uint32_t)); mips32_pracc_exec(ejtag_info, sizeof(code)/sizeof(code[0]), code, \ - sizeof(param_in)/sizeof(param_in[0]),param_in, 0, NULL, 1); + count + 2, param_in, 0, NULL, 1); free(param_in); @@ -715,7 +715,7 @@ int mips32_pracc_write_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int c } mips32_pracc_exec(ejtag_info, sizeof(code)/sizeof(code[0]), code, \ - sizeof(param_in)/sizeof(param_in[0]), param_in, 0, NULL, 1); + count + 2, param_in, 0, NULL, 1); free(param_in); @@ -778,7 +778,7 @@ int mips32_pracc_write_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int co } retval = mips32_pracc_exec(ejtag_info, sizeof(code)/sizeof(code[0]), code, \ - sizeof(param_in)/sizeof(param_in[0]), param_in, 0, NULL, 1); + count +2, param_in, 0, NULL, 1); free(param_in); -- 1.6.3.3
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
