On Sunday 15 November 2009, Dean Glazeski wrote:
> I've done an implementation of reading using an on-chip algorithm for NAND
> devices attached to ARM chips. It seems to work on my AT91SAM9260 board
> increasing nand dump from 0.2 kb/s to 9.2 kb/s. Not sure if this is the
> best implementation, so take a look. By the way, there is some room for
> refactoring between this function and the write version. I'm not sure how
> to do that so I just posted this patch with the implementation.
At first glance it seemed OK; comments still talk about "write" not "read"
though. :)
Minor style issues ... a few overlong lines, and don't do functions like
int f(...) {
...
}
Always have that left bracket at beginning-of-line.
Refactoring can come later.
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
