On Wed, 2009-11-11 at 13:54 -0700, David Brownell wrote:
> On Wednesday 11 November 2009, Zachary T Welch wrote:
> > +       for (cc = *head; cc && cc->next; cc = cc->next) ;
> 
> Style point:  such unadorned empty statements are worth avoiding.
> They're not quickly apparent when scanning code ... either their
> presence or their absence.  That translates to being bug-prone.

That was a copy and paste artifact from the original code.  You'll note
that I do add a space at the end.  That's my sign of intention. ;)
Still, I just rewrote it as a much simpler while loop.

I'll push these shortly.

--Z
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to