On Wed, 2009-11-11 at 11:54 -0700, David Brownell wrote:
> On Wednesday 11 November 2009, Zachary T Welch wrote:
> > Subsequent patches expect all command handlers to use a uniform
> > parameter naming scheme. In the entire tree, these two files used
> > non-standard 'argv' instead of 'args'. This patch reduces noise
> > required to unify all command handlers with a single definition.
>
> Not that it's a big deal ... but the convention in C has long
> been to call the argument vector "argv". Goes back to K&R days.
I am totally with you here. That was another pet peeve, but the
cost/benefit ratio did not justify doing the right thing here.
You are welcome to generate a patch after my current series are in.
> I can understand wanting a smaller patch than switching "args"
> over to "argv" though. Just ... don't call "argv" nonstandard,
> when it's more the other way around ("args" nonstandard).
Fair enough. :)
--Z
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
