Hi David, Thank you for submitting this patch! The support for Signalyzer H compiles and runs fine.
I like your idea about ctrl_write() returning negative numbers for D2XX as well, I will make the changes, it will indeed reduce amount of #ifdef. Best regards, Oleg --- www.signalyzer.com On Tue, Oct 27, 2009 at 12:41 PM, David Brownell <davi...@pacbell.net> wrote: > On Tuesday 27 October 2009, Signalyzer ( www.signalyzer.com ) wrote: >> Please find attached a subset of the Signalyzer H support that will >> compile with released version of libftdi and not require proposed >> libftdi mods. > > I committed a version with some cleanups ... please sanity check. > (Along with their config files.) > > Also, you could shrink the code a whole bunch by having your > ctrl_write() return a negative number even when using the D2XX > library, so that there's only one return code convention. That > way you would not need so many #ifdefs, and you could be sure > more of the code was *identical* in both cases ... > > It's also good to avoid assignments inside "if" conditions... > > - Dave > _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
