On Tuesday 13 October 2009, David Brownell wrote:
> Remove needless debug handler state.
> 
>  - "handler_installed" became wrong as soon as the second TRST+SRST
>    reset was issued ... so the handler was never reloaded after the
>    reset removed it from the mini-icache.
>    
>    This fixes the bug where subsequent resets fail on PXA255 (if the
>    first one even worked, which is uncommon).  I suspect other XScale
>    chips should have had problems too...
> 
>  - "handler_running" was never tested; it's pointless.

Hmm, no responses.  I'll just merge this.  I got some reports
that PXA270 saw the expected failures, but maybe IXP425 didn't.


> Plus a related bugfix: invalidate OpenOCD's ARM register cache on reset.
> It was no more valid than the XScale's mini-icache.  (Though ... such
> invalidations might be better done in "SRST asserted" callbacks.)
> ---
> Against current GIT tree.  I've cc'd the folk I know use xscales
> with OpenOCD ... pxa270 and ixp425, which are second gen parts that
> may be looser in how they handle the mini-icache, and certainly seem
> to have differences in reset handling.
> 
>  src/target/xscale.c |   28 +++++++++++-----------------
>  src/target/xscale.h |    2 --
>  2 files changed, 11 insertions(+), 19 deletions(-)
> 


_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to