Re #1 and #3: I'd combine the "add #defines" and "use #defines" into one patch myself... minor point.
Re #2: On Thursday 03 September 2009, Matt Hsu wrote: > --- a/src/target/cortex_a8.c > +++ b/src/target/cortex_a8.c > @@ -430,6 +430,13 @@ int cortex_a8_halt(target_t *target) > retval = mem_ap_write_atomic_u32(swjdp, > OMAP3530_DEBUG_BASE + CPUDBG_DRCR, 0x1); Surely that "if (retval != ERROR_OK) goto out;" is still needed here... > + /* > + * enter halting debug mode > + */ > + mem_ap_read_atomic_u32(swjdp, OMAP3530_DEBUG_BASE + CPUDBG_DSCR, > &dscr); > + retval = mem_ap_write_atomic_u32(swjdp, > + OMAP3530_DEBUG_BASE + CPUDBG_DSCR, dscr | (1 << > DSCR_HALT_DBG_MODE)); > + > if (retval != ERROR_OK) > goto out; > _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
