On Wed, 2009-07-08 at 10:04 +0200, Øyvind Harboe wrote: > ### Eclipse Workspace Patch 1.0 > #P openocd > Index: src/flash/aduc702x.c > =================================================================== > --- src/flash/aduc702x.c (revision 2490) > +++ src/flash/aduc702x.c (working copy) [snip] > + if ((retval=target_write_buffer(target, > aduc702x_info->write_algorithm->address, > + sizeof(aduc702x_flash_write_code), > (uint8_t*)aduc702x_flash_write_code))!=ERROR_OK)
Separate assignment and logical test expressions into two statements. See my just-posted patch to add a style rule to this effect for details. [snip] > + if ((retval=target_write_buffer(target, > source->address, thisrun_count * 2, buffer))!=ERROR_OK) Ditto [snip] > - retval = ERROR_FLASH_OPERATION_FAILED; > + if ((buf_get_u32(reg_params[3].value, 0, 32) & 1) != > 1) Ditto. Thanks, Zach _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
