On Sat, 2009-06-20 at 23:35 -0400, Duane Ellis wrote: > Commits - r2296 - through 2347 - are commits that fix "printf()" > -Werrors so that Cygwin will build. > > These where done (for the most part) as one file per commit so that if a > specific issue arises, it can be reverted. > This is a *nasty* bunch of mechanical changes... Agh... > > FYI - anyone writing anything using "c99" - uint32_t - a *VERY* common > type use categorically across nearly all of openocd cannot use the naked > "%x" format specifier (and this happens nearly everywhere). Instead, > one must must instead use the ["%08" PRIx32 ] combination. Ugh.
Great job! Both x86-32 and -64 compile cleanly after these patches. We need to be sure to update the Style Guide with these additional rules, as that is the best way to pass along these kinds of guidelines. As far as the ugliness, I think its portability makes it beautiful. I am going to keep telling myself that, at any rate. :) Cheers, Zach _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
