On Fri, 2009-06-19 at 19:38 -0400, Duane Ellis wrote: > Zach Welch wrote: > > On Fri, 2009-06-19 at 19:18 -0400, Duane Ellis wrote: > > > >> FYI - I committed several cygwin specific printf() warning fixes. > >> Simple cast to fix > >> > >> these where causing "-Werror" failures on cygwin. > >> > > > > I was just about to post some patches to show how to fix all of these > > correctly, as casts are not the right way to do it. > > > > I can stop... revert my patch...
By all means, continue forward; I am not sure whether it will be easier to revert the patch or simply apply a new patch that retouches the same lines. Personally, I would just go for a new patch and skip reverting. > How soon -can you have this done? Me, personally? I am not working to a specific schedule, though I realize this is a problem and have been trying to think about how to address it (short of trying to get volunteers to help clean up my mess). Since I am the one that committed it, I will take responsibility for fixing it, but I want to avoid creating more problems in doing so. > I have been dead in the water for a few days because of this... and > started fixing things. Patches are definitely welcome; they just need to do the right thing. Please feel free to continue committing patches modeled after the one that I just sent. If you have doubt about the integrity of your fixes, you should probably post them here first, which is what I was working toward with my just-posted fragment of a series. > I have other things [new work] that *need* -Werror fixed! By all means, continue supplying fixes. I am sorry to have caused these temporary problems, but the code will be well-audited once it is fixed. In that regard, I will only be glad to have made these changes if the correct fixes are going to be applied. Personally, I think these issues show that OpenOCD's type system was not working as intended on all platforms, and we have simply exposed latent bugs that needed to be addressed. And as far as I am aware, only CygWin has been broken by these changes: even MinGW32 compiles correctly, if I have interpreted Michael Fischer's recent reports correctly. Cheers, Zach _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
