On Wednesday 27 May 2009, Zach Welch wrote: > On Mon, 2009-05-25 at 23:55 -0700, David Brownell wrote: > > Make it so the magic "reset_config" keywords can be provided in any > > order. Example, "trst_and_srst" after "srst_open_drain", omitting > > the "separate" combination (which should be the default in any case). > > These sorts of improvement seems like their benefit is worth the cost of > breaking some scripts. That said, I can't tell what this might break.
Yeah, some times code review turns up things like that. Though in this case, this is also a partial response to some of the questions Wookey raised. > As such, I am reluctant to commit it until more developers chime in on > this thread. Alternatively, you could provide a patch to fix any > obvious failures in the tree (or reasoning why we don't need one). :) In-tree, no obvious failures ... so no patches needed on that basis. Out-of-tree ... one couldn't say, obviously. Which is part of the reason all out-of-tree users need to be strongly encouraged to become in-tree users. :) I'll send an updated patch by the end of the week. This needs a bit of time percolating in the tree, regardless, to help shake out any issues from the testing community. - Dave _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
