On May 15, 2009, at 6:16 AM, Øyvind Harboe wrote:

It's a faux pas to revert commits like that without discussing it with said
committer, but since it caused a SEGFAULT on Cygwin and I figured
you were asleep I didn't want you to wake up to a flurry of emails
about Cygwin SEGFAULTs...

Your fix was correct, but not complete, hence the SEGFAULT...

Well... I committed it for you as r1790, and it was just reverted in
r1793. I must therefore assume that the proper solution will be... an #if/#ifdef conditional on DARWIN or IS_CYGWIN to wrap that definition?
I am not sure at this point, but somebody needs to dig into this.

Øyvind?  You're one of our Jim experts.... :)

How's the attached patch?

Tested on:

- cygwin
- embedded host, where Jim Tcl is provided by athttpd and not embedded into
OpenOCD

Missing tests:

- mac
- linux

--
Øyvind Harboe
Embedded software and hardware consulting services
http://consulting.zylin.com
<fixmacbuild.txt>


Still an issue on OS X. Same problem, duplicate JIM symbols but now the locations have changed:

ld: duplicate symbol _Jim_SetResult_sprintf in .libs/libopenocd.lax/ libhelper.a/libhelper_la-jim-eventloop.o and .libs/libopenocd.lax/ libhelper.a/libhelper_la-command.o

So, it's a conflict between jim-eventloop.c and command.c.

--
Rick Altherr
kc8...@kc8apf.net

"He said he hadn't had a byte in three days. I had a short, so I split it with him."
 -- Unsigned



Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to