On Tue, May 12, 2009 at 8:59 PM, Andreas Fritiofson
<andreas.fritiof...@gmail.com> wrote:
> On Tue, May 12, 2009 at 8:18 AM, Øyvind Harboe <oyvind.har...@zylin.com> 
> wrote:
>> I couldn't believe my eyes when I saw what the bug was. irscan
>> has *always* been broken. I checked as far back as svn 345.
>>
>> A couple of possible explanations:
>>
>> - irscan has never really been used
>> - events have somehow conspired to hide the bugs
>> - I'm missing something
>>
>> Known problems in irscan:
>>
>> - does not support >32 bit fields(?). This maybe a problem for
>> omap devices(?)
>> - why not reuse the new drscan code?
>>
>
> I may be stupid and/or tired, but what does this mean?
>
> int num_fields= num_fields;

Mea culpa. W.r.t. being tired it was me being tired when committing
the fix. I fixed the problem, then decide to "improve" the fix a
bit more w/a search & replace of "argc / 2" w/num_fields, only
I replaced the initialization.

Why does this even compile with warnings??? :-)

Committed fix.

-- 
Øyvind Harboe
Embedded software and hardware consulting services
http://consulting.zylin.com
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to