On Sun, 2009-05-10 at 22:31 +0200, Magnus Lundin wrote:
> >
> > So some progress, but nothing more ;)
> >
> > (all: Above error is from TCL script containing "ocd_mem2array 
> > romtable_cid 32 [expr ($debugbase&0xFFFFF000) + 0xFF0] 4")
> >
> > Do you have any special patches or do I need any special configure 
> > option to enable (& compile) tclapi.c?
> >
> Standard build, nothing special, sometimes an extra (perhaps 
> unneccessary) round of
> automake
> make clean
> ./configure   --enable-jlink   --enable-ft2232_libftdi    
> --enable-maintainer-mode    --enable-parport
> make
> 
> > As already mentioned, looking into the code: ocd_mem2array is 
> > registered in tclapi_register_commands() in tclapi.c. But: It seems to 
> > me that tclapi_register_commands()  isn't called anywhere, and even 
> > worse, tclapi.c isn't compiled. I even can't find it in any
> 
> ocd_mem2array is also registered in target.c : 
> target_register_user_commands, line 1302 in head
> 
> I really suspect that tclapi.c is redundant, but I dont know

D'oh.  I should have done some more research on my own, but I figured it
was safer to bet that I was premature to remove it.  But sure enough,
your discovery made me look around, and tclapi.c appears to be entirely
redundant at this point:

"ocd_mem2array" and "ocd_array2mem" are in target.c
"ocd_flash_banks" is in flash.c
"drscan" is in jtag.c.

So... I was originally correct to remove it, and I have now done so
again because I think that it just introduced a substantial regression.
The patch has effectively been reversed in r1694.  Sorry for the noise.

The irony is that I nuked tclapi.c to eliminate possible confusion!

Cheers,

Zach

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to