On Wed, 2009-05-06 at 16:24 -0700, Zach Welch wrote:
> On Wed, 2009-05-06 at 15:50 +0200, Uwe Hermann wrote:
> > Hi,
> > 
> > On Mon, May 04, 2009 at 11:56:00AM -0700, Zach Welch wrote:
> > > The attached patch should fix the cast alignment warnings caused by
> > > jim.c on platforms with stricter alignment rules.
> > > 
> > > If you get more problems, please run the builds with --disable-werror so
> > > I can try to fix all of them in one pass.
> > 
> > Done. I've updated to r1606 and manually added your patch to the
> > build. It may take a bit longer until all architectures have been built,
> > but some are already done.
> > 
> > https://buildd.debian.org/pkg.cgi?pkg=openocd
> > https://buildd.debian.org/~luk/status/package.php?p=openocd
> > http://buildd.debian-ports.org/status/package.php?p=openocd
> > 
> 
> Not fun.  There appear to be bugs here that I cannot fix trivially.
> 
> > Building with gcc-4.4 also needs some additional fixing btw,
> > see for instance
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=527100
> > (that's not the only error, on i386 there are at least one or two more,
> > no idea for other arches).
> > 
> > You can test that with 'make CC=gcc-4.4'.
> 
> I have committed my first patch for jim.c (r1620) and another for svf.c
> (r1622).  I have some additional changes that should resolve some of the
> other issues, but there will be more work to do.
> 
> When I finish my round of changes, I will post a summary of the problems
> that remain to be fixed, so others more knowledgeable than myself can
> then look at the relevant code and fix the offending bits.  On some
> architectures, I think some of the code that generates these warnings
> could cause problems at run-time.

I believe that all but two of the warnings will be fixed with r1628. 
I convinced myself that my remaining fixes were all valid, if not as
pretty as they might become after further cleaning of the tree.

I did not address GCC 4.4 as Ubuntu Jaunty does not appear to have that
available in its stable tree.  I do not have the resources to pursue it
further at this time, but patches would be welcome.

The last problems should be two minor API issues in arm11.c that need to
be resolved, with updated TODO comments near the relevant lines of code.

Let me know if I missed any other warnings.

Cheers,

Zach

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to