Feel free to drop my patch. This effort was quick and painless, and functional improvements from others can be added first. This was mostly an initial audit of the code and an quick test to see if the code module was free for further patching. I somewhat expected a conflict, since I did not scour the list to see what work might be outstanding.
--Z On Thu, 2009-03-26 at 17:33 -0700, Jeff Williams wrote: > Hi Zach, > > My only concern is that we're still waiting on some kind of resolution > on JLink changes to support MC1322x. Last we heard Duane was "waiting > for the dust to settle". Is there any way to coordinate these two > efforts, so that we don't end up with a mess of wasted work? For > instance refactoring for "taste and style" could potentially cause me > a lot of headache in getting the MC1322x work committed. > > Jeff > > El Mar 26, 2009, a las 16:26 , Zach Welch escribió: > > > Howdy, > > > > I have attached a patch to simplify the jlink.c file, which I wanted > > to > > submit before trying to do some more work on that module. With these > > changes, the code will fit neatly into an 80 column terminal and > > should > > be much easier to read. There should not be _any_ functional changes; > > even the pre-existing warnings should be intact. > > > > That said, I did invert numerous logic tests to allow their blocks of > > the code to require less indentation. The biggest improvement in this > > regard was in jlink_usb_message, which became nearly flat after > > unwinding its logic. I also re-factored most of jlink_execute_queue > > into a nearby static helper function, mostly for the same reason. > > > > To aid reviewing this patch, I suggest applying it to a working copy > > and > > using 'svn diff -x -w' to mask the lines that only changed whitespace. > > This reduces the number of lines reported changed by over half. > > > > Cheers, > > > > Zach Welch > > Corvallis, OR > > <openocd-jlink-cleanup- > > r1433.patch>_______________________________________________ > > Openocd-development mailing list > > Openocd-development@lists.berlios.de > > https://lists.berlios.de/mailman/listinfo/openocd-development > _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
