> 1) A bad assumption is made in the above code that the number > of bits is 7 or less. The above code should be changed to > work with more than 7 bits or at least report the error if > bits argument is greater than 7.
I had proven that you can reach from every state to every state in 7 or less shifts. After I was sure about this, I removed the the test that checked for an overflow. I should have made a comment about this, because a code surveyor without this knowledge would detect a glaring bug. Maybe the check should be put back anyway, even when we know that it takes 7 or less steps in case someone changes the code later. > 2) current_state is no longer usable like above. Use > tap_set_state(). Okay, I missed that function in OpenOCD. My own code, where I made this function for, doesn't have that. The state tracking in my code was via the MYVERBOSE(), that also ... > 3) It is good that when using tap_set_state() there will be > state tracking/logging through ALL states, not just the > endpoints of a multi-state move. ... showed how it was going via all states and did not only show the endpoints. _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
