On Dec 24, 2008, at 10:36 AM, SimonQian wrote:
Hi,> Look at one of the existing interfaces in src/jtag. Create a new .h/.c file and implement your interface. > Modify the Makefile.am in src/jtag and configure.in in src/ to add the option to enable your interface. > Then submit a patch with all the changes to this mailing list. There is an example of such a patch from a week or so ago (look for rlink in the mailing list archives).So a patch is enough? Attachment is the patch for my tool. Is it OK? Need any other docs? 2008-12-25 Best Regards, Simon Qian SimonQian(simonq...@simonqian.com) ---- www.SimonQian.com <trunk.patch>
The majority of this looks good. A few minor changes I would like to see:
- Add the new interface type and its options to the documentation (doc/ openocd.texi) - Don't use _DEBUG_USB_COMMS_ and _DEBUG_JTAG_IO_. LOG_DEBUG ensures that they are only output if someone uses 'debug_level 3'. I'd rather get all the debug info than dig around trying to find the #define that I need to enable. - Break the 'vsllink_usb' command into a few subcommands: vid, pid, bulkout, bulkin. That way the line in the config isn't so cryptic. - The following LOG_INFO line in vsllink_init should probably have some explanation rather than just dumping what is in the usb input buffer:
LOG_INFO(VSLLINK_usb_in_buffer + 2);
It also generates a compiler warning due to the buffer being unsigned.
- Compiler warning for the usb_bulk_write() in vsllink_usb_write():
vsllink.c:1242: warning: pointer targets in passing argument 3 of
‘usb_bulk_write’ differ in signedness
- Compiler warning for the usb_bulk_read() in vsllink_usb_read():vsllink.c:1262: warning: pointer targets in passing argument 3 of ‘usb_bulk_read’ differ in signedness
The compiler warnings and documentation are a "must fix" for me to commit it. I strongly urge breaking the vsllink_usb command into subcommands. The debug #defines are optional.
-- Rick Altherr kc8...@kc8apf.net"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
