Zitat von Luiz Augusto von Dentz <luiz.de...@gmail.com>: > Hi Hendrik, > > On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler > <p...@hendrik-sattler.de> wrote: >> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz: >>> > Note that those are build warnings, not build errors (except when using >>> > maintainer mode). >>> >>> Which is the whole point to force fixing and not just ignore them. >> >> Your commit message is wrong, that's what I meant! > > I did rebase your changes on top of my build fixes here: > git://gitorious.org/~vudentz/openobex/vudentz-clone.git > > If you are ok, I will resend my 2 build fixes again. I also did a > quick review on the other changes and noticed at least one use of c++ > comment style '//'
Citing from the ISO 9899-1999 (C99) standard: "6.4.9 Comments 1 Except within a character constant, a string literal, or a comment, the characters /* introduce a comment. The contents of such a comment are examined only to identify multibyte characters and to find the characters */ that terminate it. 2 Except within a character constant, a string literal, or a comment, the characters // introduce a comment that includes all multibyte characters up to, but not including, the next new-line character. The contents of such a comment are examined only to identify multibyte characters and to find the terminating new-line character." It's the year 2011, so using /* some comment */ or // some comment are both absolutely valid C. Johan also mentioned this and I gave him the same response. > and missing note about action command support on > ChangeLog, can you fix those? Yes. > And please lets be more careful with > codestyle, there are some files with space mixed with tabs and a lot > of empty likes with tabs. I'll check that. The long week-end in Germany should give me enough time :) > If those issues are fixed we can do 2.0 release. Where? HS ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
