On Thu, 3 Sep 2026 14:26:53 GMT, Michael Strauß <[email protected]> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line
>> 832:
>>
>>> 830: * control will typically present the mnemonic surrounded by
>>> parentheses.
>>> 831: * The extended mnemonic might be hidden on certain platforms and
>>> only displayed
>>> 832: * then the mnemonic modifier key is pressed.
>>
>> `then -> when` I think?
>
> Can you indent the list items, and remove the superfluous `<p>...</p>` and
> `</li>` elements? Formatting lists as flat text makes it _really_ hard to
> read.
>
> Here's an example:
>
> <ul>
> <li><b>Simple mnemonic</b>: the first character preceded by the first
> {@code _}
> character will be treated as the mnemonic. For example, "E_xit" will
> cause
> ...
> <li><b>Extended mnemonic</b>: an optional representation of a mnemonic is
> {@code _(c)}, where {@code c} is the mnemonic character. For example,
> ...
> </ul>
Looks much better now. I'm wondering, is there a reason you're using 2 spaces
of indentation instead of the usual 4? With the latter, it happens that the
first line following the `<li>` and the subsequent lines start with the same
indentation; with 2 spaces, the subsequent lines are not lined up with the
first line.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2287#discussion_r3933847917
