On Tue, 1 Sep 2026 16:25:22 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Remove weak reference for drawing context
>> - Fix stroke width / dash lengths when scale != 1.0, and fix clips
>> - Keep user set global alpha as-is
>> - GraphicsContext#clipRect no longer clobbers existing path
>> - Support direct buffers and slices for WritableImage#getDrawingContext
>> - Extend tests for dirty rect, and fix dirty rect for stroked text
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWDrawingContext.java
> line 201:
>
>> 199: public SWDrawingContext(com.sun.prism.Image img,
>> Consumer<Rectangle> pixelsDirty) {
>> 200: int[] data = switch (img.getPixelBuffer()) {
>> 201: case IntBuffer ib -> ib.array();
>
> is it possible to get a sliced array at this point?
> IntBuffer::array() ignores the arrayOffset so the subsequent operations might
> overwrite wrong elements.
I've adjusted this to allow for both slices and direct buffers.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3931970929
