On Wed, 15 Jul 2026 17:59:18 GMT, Jose Pereda <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> assign back to helper > >> My only comment is whether tests in general should use public APIs instead >> of internal classes like ExpressionHelper. Once >> https://github.com/openjdk/jfx/pull/1081 is in these tests will likely >> break, right? > > But that will happen with the already existing `ExpressionHelperTest` file > (more than 30 tests), and many other tests that are using internal classes in > test.com.sun.javafx... It is not always possible to just use public API/shims > to get to test internal classes, is it? > I would ask @jperedadnr how significant are the issues caused by this and can > they be worked around in the meantime? @nlisker as I described in the [JBS ticket](https://bugs.openjdk.org/browse/JDK-8387655?focusedId=14890583&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14890583), the issue happened with an internal implementation in JavaFX classes (PopupWindows and focusedProperties), but I could finally isolate to the much more simple BooleanPropertyTest test. There could probably be some workarounds, given that the root cause of the problem is now well known, like adding a dummy change listener just to not get _all_ the listeners removed in the real scenario, but of course this shouldn't be needed once this small fix is in (and hopefully #1081). ------------- PR Comment: https://git.openjdk.org/jfx/pull/2200#issuecomment-4983838156
