On Wed, 15 Jul 2026 06:16:21 GMT, Ambarish Rapte <[email protected]> wrote:

>> Update Webkit to v625.1
>> Build and sanity testing on Mac, Linux and Windows platforms is all green.
>> 
>> Please note that this PR will be integrated after the fork of jfx27.
>> 
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ambarish Rapte has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review corrections

The latest changes look good. And thanks for the explanation.

@tiainen @johanvos One thing to note, which would be easy to miss amongst the 
myriad of native WebKit changes, is that we had to bump the version of cmake to 
a more recent version of cmake 3:


diff --git a/build.properties b/build.properties
index cc65b00676..7cdd1562db 100644
--- a/build.properties
+++ b/build.properties
@@ -108,7 +108,7 @@ jfx.build.windows.msvc.version=VS2022-17.13.2+1.0
 jfx.build.macosx.xcode.version=Xcode15.4+1.0
 
 # Build tools
-jfx.build.cmake.version=3.22.3
+jfx.build.cmake.version=3.31.12
 jfx.build.clang.version=19.1.7
 jfx.build.ninja.version=1.8.2
 jfx.build.ant.version=1.10.5


You will likely see build failures with the older cmake.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2207#issuecomment-4981154180

Reply via email to