On Mon, 9 Mar 2026 19:31:35 GMT, Dmitry Markov <[email protected]> wrote:

> Documented the IllegalArgumentException thrown when the initial directory was 
> invalid, and improved the exception description to be more precise and 
> informative.

Providing a comment. The change is minor but I think it should go through CSR  
@kevinrushforth  and so minimum two reviewers.
/Reviewers 2

modules/javafx.graphics/src/main/java/com/sun/glass/ui/CommonDialogs.java line 
239:

> 237:                 }
> 238:             } else {
> 239:                 throw new IllegalArgumentException("The initial 
> directory does not exist, is invalid or is not accessible");

How does this sound ?

`The initial directory does not exist or is not a directory or is not 
accessible.`

and in FileChooser.java file, only prepend word `if` to same statement
`@throws IllegalArgumentException if the initial directory does not exist or is 
not a directory or is not accessible.`

-------------

Changes requested by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2101#pullrequestreview-3919725848
PR Review Comment: https://git.openjdk.org/jfx/pull/2101#discussion_r2909313352

Reply via email to