On Fri, 27 Feb 2026 08:21:43 GMT, Joeri Sykora <[email protected]> wrote:
>> The flags /D_STATIC_CPPLIB and /D_DISABLE_DEPRECATE_STATIC_CPPLIB were >> required on Visual Studio 2010 to avoid bundling msvcp*.dll. These flags do >> not work since Visual Studio 2012. >> >> These flags are initially added to common set of Visual Studio compiler >> flags when JavaFX is built. >> >> Before JDK-8289174, these flags were then removed if JavaFX is built on >> Visual Studio 2010. >> After JDK-8289174, these flags are always removed when JavaFX is built. >> >> As the addition and removal of these flags are now effectively no-op, >> references to these flags can be removed. > > I had no issues during compilation and the changes look good to me. @tiainen @lukostyra Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2083#issuecomment-3982031357
