On Thu, 19 Feb 2026 16:50:33 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/parser/CssNumberParser.java > line 304: > >> 302: * @see <a href="https://arxiv.org/pdf/2101.11408";>Number Parsing >> at a Gigabyte per Second</a> >> 303: */ >> 304: private static final long[] T = new long[] { > > Warning about a large binary blob of unknown origin in the source. > > I suggest we do two things here: > 1. add a comment explaining what it is and how it is computed in general terms > 2. provide the code that generates it, so it can be reviewed at the source > level. For example, it might be in a form of a unit test which generates the > array and compares it to the one here. I think the comment already explains what it is, including a link to a script that generates it. The script itself is now in the `powersOfFive()` unit test. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2069#discussion_r2829118735
