On Fri, 13 Feb 2026 22:29:24 GMT, Andy Goryachev <[email protected]> wrote:
> This works well on macOS 26.2 (did not test windows/linux). > > My biggest gripe is the amount of extra code and effort brought in to > slightly improve the flickering color. > > In fact, I suspect the added computation might actually exacerbate the > problem in the case of image, since it has to compute the background color > using non-trivial and time-consuming algorithms. > > I would think it might work just as well simply by using the black/white > background corresponding to the current theme. I am curious what other > reviewers would say. It's a valid question. I will point out, however, that the runtime cost shouldn't be too high, as the sampling fidelity is reduced for large images (small images are sampled more often to capture more detail, large images are sampled less often because their details are usually spread over a larger area). There are many examples where just black or white works well enough. But playing around with it, I can just as easily come up with examples where it doesn't work so well, especially with a colorful background. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2068#issuecomment-3901929864
