On Fri, 16 Jan 2026 22:29:35 GMT, Andy Goryachev <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove space >> - Use for loops again >> - Remove unused method > > modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java > line 265: > >> 263: child = null; >> 264: } >> 265: // minimal protection against concurrent update of the >> list. > > see, this is a worrisome comment - and perhaps the value of this PR would be > much higher if you can demonstrate that the concurrency is not an issue. I think that bar is too high, how would you even begin to demonstrate that it _isn't_ an issue? This class iterates over the very same list in six different places, none of which are "protected" with a try-catch block. I would think that this fact should be enough to say that even if concurrent modification was an issue, it must be solved differently. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2043#discussion_r2700241743
