On Mon, 12 Jan 2026 16:24:42 GMT, Michael Strauß <[email protected]> wrote:
>> The `HeaderBar` control currently has three areas: `leading`, `center`, and >> `trailing`. Additionally, there's `leftSystemInset` and `rightSystemInset`, >> which are not RTL adjusted. I've come to the understanding that there is no >> particularly good reason for this, because every time you would want to use >> this information for layout purposes, it should also be adjusted for RTL. >> >> With this in mind, there are three changes for the `HeaderBar` control: >> 1. Rename `leading` to `left`, and `trailing` to `right`, which aligns the >> terminology with `BorderPane`. >> 2. Adjust `leftSystemInset` and `rightSystemInset` for RTL. >> 3. Make `leftSystemInset`, `rightSystemInset`, and `minSystemHeight` >> attached properties for `Stage`. >> >> With this change, the `HeaderBar` control is more semantically consistent >> and easier to use, and the renamed `left` and `right` areas now show its >> close relationship with `BorderPane`. >> >> In addition to that, two new `HeaderDragType` constants are added: >> * `TRANSPARENT`: when set on a node, excludes the node from draggable-area >> hit testing >> * `TRANSPARENT_SUBTREE`: the same, but also applies to the node's subtree > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > constant name The code changes look good to me. Thanks for documenting some of the trickier aspects of this. So far my manual testing on macOS looks good. In parallel with finishing up a little light testing on Windows and Linux, I am running a headful test on our CI systems. Once all passes, I'll approve. ------------- PR Review: https://git.openjdk.org/jfx/pull/1936#pullrequestreview-3658212973
