On Tue, 6 Jan 2026 20:08:08 GMT, John Hendrikx <[email protected]> wrote:
>> I might disagree here: if we are not planning to fix these thousands of >> warnings, the warning should be disabled. >> >> I do want to point you to a problem (unrelated to this PR) - if you try to >> edit CssParser (a simple whitespace change for example), you'll always get >> these in Eclipse, quite annoying: >> >> >> Description Resource Location >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3029 >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3219 >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3272 >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3287 >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3612 >> Cannot infer type arguments for ParsedValueImpl<> CssParser.java line >> 3656 > > Yeah, it is just a difference of opinion in the ECJ compiler and javac. It > can probably be written slightly differently so it compiles properly under > both. > > Also, I did fix a lot of those, but that PR died. Fixing ParsedValue however > is IMHO a waste; that thing should never have had generic arguments in the > first place; it is a classic example where adding generics costs more than it > benefits. yeah. it just bothers me that before it was quietly ignored and now any time I touch the file it gives me a bunch of errors. we could complain to Eclipse folks or just fix it ourselves... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1990#discussion_r2666153371
