On Mon, 29 Dec 2025 19:04:53 GMT, Marius Hanl <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update copyright year
>> - Fix test format
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/PasswordFieldTest.java
> line 102:
>
>> 100:
>> 101: @Test
>> 102: public void accessibleAttributeText() {
>
> Probably Minor, but having those 4 cases as small separate tests (2 or 4
> tests) with a good test name for each is (at least IMO) a little bit more nice
I think this is ok, especially if all the cases are exercised (I also like
writing these kinds of extended tests). Unless there is a good reason, I'd
leave this decision up to the author.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2020#discussion_r2662499802
