Currently we don't set any texture filtering & addressing modes for 3D textures 
in Metal pipeline.
Default 3D texture filtering is "nearest" for Metal textures, but we use 
"linear" filtering by default for 3D textures in case of OpenGL.
Default addressing mode is "clamp_to_edge" in Metal textures, but we use 
"repeat" addressing mode for 3D textures in OpenGL.

Metal should use same default filtering & addressing modes for 3D textures as 
in OpenGL pipeline.
Under this issue we are trying only to match defaults of Metal to OpenGL 
pipeline.

We don't update the filters/addressing modes for 3D textures once created.
We have open enhancements like https://bugs.openjdk.org/browse/JDK-8324594 
where we might provide API's to set sampler states for 3D textures in future.

Functional and performance testing is green with this update.

-------------

Commit messages:
 - revert default MTL
 - force MTL
 - Use set device parameters for 3D call
 - 8373232: Set default filters for 3D metal textures

Changes: https://git.openjdk.org/jfx/pull/2005/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=2005&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8373232
  Stats: 83 lines in 7 files changed: 73 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jfx/pull/2005.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2005/head:pull/2005

PR: https://git.openjdk.org/jfx/pull/2005

Reply via email to