On Tue, 2 Dec 2025 17:10:00 GMT, Andy Goryachev <[email protected]> wrote:
>> Fixing a bug in `SimpleViewOnlyStyledModel.lastParagraph()` which breaks
>> adding text segments after a `Region`-based paragraph.
>>
>> Test cases:
>>
>> @Test
>> public void addTextAfterRegion() {
>> SimpleViewOnlyStyledModel m = new SimpleViewOnlyStyledModel();
>> m.addParagraph(() -> new Region());
>> m.addNodeSegment(() -> new Region());
>> assertEquals(2, m.size());
>> }
>>
>> @Test
>> public void addTextAfterRegionAfterText() {
>> SimpleViewOnlyStyledModel m = new SimpleViewOnlyStyledModel();
>> m.addNodeSegment(() -> new Region());
>> m.addParagraph(() -> new Region());
>> m.addSegment("text");
>> assertEquals(3, m.size());
>> }
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains two additional
> commits since the last revision:
>
> - Merge branch 'master' into 8372438.non.text.paragraphs
> - fix
LGTM , the test works with the fix
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1983#issuecomment-3627700881
