On Mon, 3 Nov 2025 18:08:21 GMT, Andy Goryachev <[email protected]> wrote:

> Yes some of its styleable properties are present in modena.css and 
> caspian.css - like `color-picker-grid` selector for instance. It is not, 
> however, specified in the CSS reference at all (even though the skin itself, 
> `ColorPickerSkin` is a public class).

Ideally, everything used by `modena.css` would be documented in the CSS guide.

> So if one wants to provide a custom ColorPicker skin, there is no middle 
> ground - either use the stock implementation with a limited range of 
> customization, or create your own. This is the kind of difficulties one finds 
> working with JavaFX - it's extremely difficult to extend.

This highlights the inadequacy of these type of undocumented "back door" 
properties.

> So adding (an undocumented) styleable property to `ColorPalette.java` might 
> solve the issue described in the ticket, without requiring a CSR since no 
> public APIs are introduced, right?

I'd prefer not to implement this enhancement by adding even more hidden, 
undocumented, CSS properties. How many such properties are there on 
ColorPickerSkin? Would it make sense to document them or would that open a 
larger can of worms?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1954#issuecomment-3481919528

Reply via email to