On Sat, 11 Oct 2025 12:07:49 GMT, Michael Strauß <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed to HTML comments > > modules/javafx.graphics/src/main/java/javafx/scene/input/MouseDragEvent.java > line 132: > >> 130: /** >> 131: * This event occurs when the gesture ends. It is delivered exactly >> once to the source node/scene, and is always the >> 132: * last event in the full press-drag-release process. It is >> delivered even when the mouse is outside the application. > > 1. `It is delivered exactly once to the source node/scene`: you could > probably remove `/scene`, it is implied by the way events work. Maybe be a > bit more precise: `It is delivered exactly once to the node on which the > press-drag-release gesture was started`. > 2. `outside the application` is a bit vague, as applications don't have a > spatial extent. How about: `It is delivered even when the mouse was released > outside of the window`. 1. I'm not sure why scene is implied from node considering it's not a node - the language often used is "gesture source". This is also why I don't understand why remove that term and replace it with its meaning. 2. Changed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1873#discussion_r2422829570
