On Tue, 30 Sep 2025 20:08:55 GMT, Michael Strauß <[email protected]> wrote:

>> Currently, the color scheme of a system-decorated stage is as follows:
>> * On Windows, the title bar is always light (even if the OS color scheme is 
>> dark).
>> * On macOS and Linux, the title bar is light or dark depending on the OS 
>> color scheme.
>> 
>> The expected behavior is that the title bar matches the color scheme of the 
>> `Scene`.
>> If an application doesn't specify a color scheme, the title bar color should 
>> match the OS color scheme.
>> 
>> This PR fixes the behavior for Windows and macOS, but not for Linux (there's 
>> no good way to do that).
>> Depending on how you look at it, this is either a bug fix or an enhancement.
>
> Michael Strauß has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains four commits:
> 
>  - explicitly use wide string functions
>  - Merge branch 'master' into feature/dark-window-frame
>  - Merge branch 'master' into feature/dark-window-frame
>    
>    # Conflicts:
>    #  modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m
>  - Window decorations adapt to color scheme

rebooted my machine.  works as expected on macos 15.7 M1

btw, should the rest of the ui come out in dark mode when 
`Scene.Preferences.colorSceme=DARK` is set?

<img width="1494" height="758" alt="Screenshot 2025-10-01 at 11 15 06" 
src="https://github.com/user-attachments/assets/d06ed1c1-098d-4490-8c6e-c8ff10ba9213";
 />

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1845#issuecomment-3357531730
PR Comment: https://git.openjdk.org/jfx/pull/1845#issuecomment-3357542680

Reply via email to